Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: text decoding allows SharedArrayBuffer #32203

Closed
wants to merge 1 commit into from
Closed

util: text decoding allows SharedArrayBuffer #32203

wants to merge 1 commit into from

Conversation

bmeck
Copy link
Member

@bmeck bmeck commented Mar 11, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Fixes: #32199

Tests are needed to be placed in upstream at https://github.com/web-platform-tests/wpt which is where all our TextDecoder tests come from.

@nodejs-github-bot nodejs-github-bot added the encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. label Mar 11, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29741/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2020
@bmeck
Copy link
Member Author

bmeck commented Mar 11, 2020

upstream has the tests already, but updating our fixtures is apparently not clean: #32208

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 12, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29782/ (:white_check_mark:)

@addaleax
Copy link
Member

Landed in 417d847

@addaleax addaleax closed this Mar 13, 2020
addaleax pushed a commit that referenced this pull request Mar 13, 2020
@bfarias-godaddy @addaleax
util: text decoding allows SharedArrayBuffer
417d847 
PR-URL: #32203
Fixes: #32199
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 17, 2020
@bfarias-godaddy @BridgeAR
util: text decoding allows SharedArrayBuffer
3845754 
PR-URL: #32203
Fixes: #32199
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@bfarias-godaddy @MylesBorins
util: text decoding allows SharedArrayBuffer
fa1fa31 
PR-URL: #32203
Fixes: #32199
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@bfarias-godaddy @targos
util: text decoding allows SharedArrayBuffer
58c6422 
PR-URL: #32203
Fixes: #32199
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

textDecoder.decode() doesn't accept SharedArrayBuffers
9 participants
@bmeck @nodejs-github-bot @addaleax @jasnell @lpinca @cjihrig @devsnek @BridgeAR @bfarias-godaddy